Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eskimi bidder documentation #4471

Merged
merged 2 commits into from
May 18, 2023
Merged

Add Eskimi bidder documentation #4471

merged 2 commits into from
May 18, 2023

Conversation

mrobakowski
Copy link
Contributor

@mrobakowski mrobakowski commented Apr 6, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit a67103c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/645a4e601ff82a000861eb33
😎 Deploy Preview https://deploy-preview-4471--prebid-docs-preview.netlify.app/dev-docs/bidders/eskimi
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrobakowski mrobakowski marked this pull request as ready for review April 6, 2023 14:10
gvl_id: 814
sidebarType: 1
schain_supported: true
floors_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleased add additional meta information found here: https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

  • media_types : banner // this is not needed, but makes it clearer
  • safeframes_ok: true/false // makes the integration easier for publishers
  • ortb_blocking_supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add additional bidder parameters for ortb blocking? In the adapter code we're using prebid.js's ortb converter, but that won't populate bcat, badv and so on, right? So I guess for the initial version ortb_blocking_supported will be set to false, but we're going to update it later as our backend supports it fully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrobakowski sounds like a good plan to me. Merging!

Copy link
Contributor Author

@mrobakowski mrobakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

. (edit: I tried using github spaces to fix the PR and the buttons don't do what I thought they would)

@mrobakowski mrobakowski requested a review from muuki88 May 18, 2023 13:21
@fowler446 fowler446 merged commit 66cc3ad into prebid:master May 18, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Add Eskimi bidder documentation

* add safeframes_ok and ortb_blocking_supported fields to eskimi bidder docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants